Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use with other installations of helm #23

Closed
geisterfurz007 opened this issue Jan 9, 2022 · 3 comments · Fixed by #24
Closed

Allow use with other installations of helm #23

geisterfurz007 opened this issue Jan 9, 2022 · 3 comments · Fixed by #24
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task

Comments

@geisterfurz007
Copy link
Contributor

geisterfurz007 commented Jan 9, 2022

Is your feature request related to a problem? Please describe.

I am using the helm3 plugin/addon of microk8s which is run using microk8s helm3; for easier personal use I just aliased that to helm but run.sh doesn't pick that up causing the datree plugin to not compile the chart which in turn causes a "No files detected" error since this line (specifically helm show chart) fails as the command isn't known:

elif [[ $helm_chart_location == "" && $(helm show chart $1 2> /dev/null | grep apiVersion) == apiVersion* ]]; then

Describe the solution you'd like

Some flag / env variable for the script to provide an alternative path / way of calling helm to allow executing helm that is prebundled with other tools and thus requires a different command to run.

Describe alternatives you've considered

  • Modifying the installed run.sh file to include the alias at the top of the file locally
  • Dropping a helm executable somewhere in the path that essentially serves as the alias

Additional context
-

@geisterfurz007 geisterfurz007 added the enhancement New feature or request label Jan 9, 2022
@dimabru
Copy link
Contributor

dimabru commented Jan 9, 2022

Hi @geisterfurz007,
Thanks a lot for reporting this!
I'm marking this issue as up for grabs

@dimabru dimabru added the up for grabs Looking for a contributor to take this task label Jan 9, 2022
@dimabru
Copy link
Contributor

dimabru commented Jan 9, 2022

@geisterfurz007
BTW, if you were able to find the issue location and suggest a solution I think you are definitely skilled enough to fix this yourself :)
If you'd like to take this on, please let me know. We can schedule a zoom call and talk about a possible solution

@geisterfurz007
Copy link
Contributor Author

I think I might actually have something in mind; I will try around with it later and open a PR if it works; otherwise I Will gladly come back to the zoom call offer, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants