Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A video with multiple audio tracks loses the audio when merged #12

Closed
mattio opened this issue Mar 3, 2021 · 1 comment
Closed

A video with multiple audio tracks loses the audio when merged #12

mattio opened this issue Mar 3, 2021 · 1 comment

Comments

@mattio
Copy link
Contributor

mattio commented Mar 3, 2021

Hello! Thanks for this library!

I ran into a scenario where a video was being recorded with ReplayKit in custom fashion and it ended up having multiple audio tracks. When I merged that video with another, there was some audio loss.

I believe I found the place in the code that assumed a single audio track and updated it to allow for multiple. I'll submit a PR for the change that worked in my scenario. Hope you find it useful enough to merge!

@Datt1994
Copy link
Owner

Datt1994 commented Mar 4, 2021

Hello @mattio,

Thanks for contribution

@Datt1994 Datt1994 closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants