try using native bitwise operations without checking lua version #177
Conversation
http/bit.lua
Outdated
| bor = function(a, b) return a | b end; | ||
| bxor = function(a, b) return a ~ b end; | ||
| }]], info.source))() | ||
| -- Lua 5.1's load function doesn't support reading strings, only |
There was a problem hiding this comment.
Yeah, I guess it's six of one, half-dozen of the other.
This could be replaced with something like "local l = load; if loadstring then l = loadstring"
I can switch to something like that if you prefer, let me know!
There was a problem hiding this comment.
I guess loadstring doesn't have a source argument; so load is best.
It annoys me a little that we don't use straight up load in newer versions of lua.
I just realised we already depend on compat-5.3 in lua 5.1, so how about:
local load = load
if _VERSION == "Lua 5.1" then
load = require "compat53.module".load
endThere was a problem hiding this comment.
re: loadstring - in the docs they list the second parameter as chunk instead of source, but it's the same thing, loadstring should work and show the source filename as intended.
There was a problem hiding this comment.
See latest push, I just did local load = loadstring or load
There was a problem hiding this comment.
I don't want to use loadstring if load is available.
|
See #180 |
This is an alternative to #174
Rather than relying on
_VERSION == "Lua 5.3", this just tries loading the Lua 5.3+ wrapper table no matter what. Assuming future versions of Lua keep bitwise ops, this should work on future versions of Lua.Plus it should be compatible with forks/renames/etc.