Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daux ignore all non-asci charactor in file name when generating html #183

Closed
StarDuster opened this issue Dec 21, 2019 · 3 comments
Closed
Labels
bug Waiting for release fixed, waiting for a release

Comments

@StarDuster
Copy link

StarDuster commented Dec 21, 2019

To Reproduce

Steps to reproduce the behavior:

  1. all-new install from docker, no config.json
  2. create docs/ directory (in tmpfs, in my case) with non-asci charactors (e.g. Chinese 汉字)
  3. run docker run --rm -it -w /build -v "$PWD":/build daux/daux.io daux generate
  4. daux generate wrong file name of html, it just skip all non-asci char in file name

Expected behavior

generate directory and html file with Chinese charactors

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • PHP_VERSION=7.3.12

Additional context

Is any more config needed to generate from non-asci file ?

There is a official example 你好世界.html include Chinese charactor, how to make it?

Anyway, charactors in md file converted as expected.

@onigoetz
Copy link
Contributor

Hello, thanks for the report, I noticed the same with my most recent changes, I will look into it.

@onigoetz onigoetz added the bug label Dec 29, 2019
@onigoetz
Copy link
Contributor

The issue was introduced by fixing #86 in 0.9.2 so in the meantime, you can use version 0.9.1.

I'm working on a fix.

onigoetz added a commit that referenced this issue Dec 29, 2019
onigoetz added a commit that referenced this issue Dec 29, 2019
@onigoetz onigoetz added the Waiting for release fixed, waiting for a release label Dec 29, 2019
@onigoetz
Copy link
Contributor

The fixes discussed in this issue are available in version 0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Waiting for release fixed, waiting for a release
Projects
None yet
Development

No branches or pull requests

2 participants