Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.json defines "image" property, so you can't unset it #205

Closed
Faldrian opened this issue Apr 29, 2020 · 2 comments
Closed

global.json defines "image" property, so you can't unset it #205

Faldrian opened this issue Apr 29, 2020 · 2 comments

Comments

@Faldrian
Copy link

Describe the bug
You can't generate a documentation with the default theme and not have an "HomepageImage" on the global landing page.

To Reproduce
Steps to reproduce the behavior:

  1. create a new project with an index.md and another Markdown file (so generation works)
  2. Create a global.json file next to it and define title and author. No "image" is defined.
  3. The generated documentation will habe an image with «src=""» embedded, resulting in alt-text shown.

Expected behavior
If "image" would not be defined, you can leave it blank and the template logic of "hasImage" would work.

Additional context
This is a minor thing... but causes me to use my own template or a blank image, which is not ideal. ^^

@Faldrian Faldrian changed the title global.json defines "image" properts global.json defines "image" property, so you can't unset it Apr 29, 2020
@onigoetz onigoetz added the Waiting for release fixed, waiting for a release label May 4, 2020
@onigoetz
Copy link
Contributor

onigoetz commented May 4, 2020

Hi, I made a fix in the master branch, you can try to take the project from dev-master or the latest docker image, I'll release the fix soon

@onigoetz
Copy link
Contributor

onigoetz commented Jun 6, 2020

Hi, this has been released in Version 0.14.0

@onigoetz onigoetz closed this as completed Jun 6, 2020
@onigoetz onigoetz removed the Waiting for release fixed, waiting for a release label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants