[REQUEST] Follow Type=Link standard desktop entries with drun #1166
Labels
Milestone
Comments
|
@DaveDavenport would you be open to a PR introducing this behavior? |
|
Yes. I guess best is to launch URL with |
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 25, 2020
From the [freedesktop spec][1]: > This specification defines 3 types of desktop entries: > Application (type 1), Link (type 2) and Directory (type 3). To allow > the addition of new types in the future, implementations should > ignore desktop entries with an unknown type. This commit adds an enum to capture these types, and adds `type` to DRunModeEntry. [1]: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 25, 2020
Note that we're introducing some logic that will differ depending on the Desktop entry type (Application or Link). The logic is: - if entry is Application type, - then Exec is required - and the value is saved in .exec - and drun_mode_result calls exec_cmd_entry - if entry is Link type, - then URL is required (but is not saved in the DRunModeEntry) - and drun_mode_result calls new function launch_link_entry part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 25, 2020
Note that this introduces a new dependency on xdg-open, which may not be installed. In that case, rofi will display an error dialog with something like: "Failed to execute child process xdg-open (No such file or directory)" which hopefully is explanatory enough for folks. part of davatorium#1166
|
I've opened #1168 with a proposed implementation for this. |
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
In previous commit, this was a hard-coded string. part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
In previous commit, this was a hard-coded string. part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
Note that we're introducing some logic that will differ depending on the Desktop entry type (Application or Link). The logic is: - if entry is Application type, - then Exec is required - and the value is saved in .exec - and drun_mode_result calls exec_cmd_entry - if entry is Link type, - then URL is required (but is not saved in the DRunModeEntry) - and drun_mode_result calls new function launch_link_entry part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
Note that this introduces a new dependency on xdg-open, which may not be installed. In that case, rofi will display an error dialog with something like: "Failed to execute child process xdg-open (No such file or directory)" which hopefully is explanatory enough for folks. part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
In previous commit, this was a hard-coded string. part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
Note that we're introducing some logic that will differ depending on the Desktop entry type (Application or Link). The logic is: - if entry is Application type, - then Exec is required - and the value is saved in .exec - and drun_mode_result calls exec_cmd_entry - if entry is Link type, - then URL is required (but is not saved in the DRunModeEntry) - and drun_mode_result calls new function launch_link_entry part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
Note that this introduces a new dependency on xdg-open, which may not be installed. In that case, rofi will display an error dialog with something like: "Failed to execute child process xdg-open (No such file or directory)" which hopefully is explanatory enough for folks. part of davatorium#1166
flavorjones
added a commit
to flavorjones/rofi
that referenced
this issue
Aug 26, 2020
In previous commit, this was a hard-coded string. part of davatorium#1166
DaveDavenport
pushed a commit
that referenced
this issue
Aug 26, 2020
* [DRun] Introduce data structure changes for Link desktop entries From the [freedesktop spec][1]: > This specification defines 3 types of desktop entries: > Application (type 1), Link (type 2) and Directory (type 3). To allow > the addition of new types in the future, implementations should > ignore desktop entries with an unknown type. This commit adds an enum to capture these types, and adds `type` to DRunModeEntry. [1]: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html part of #1166 * [DRun] Sanity check Link entries and capture the URL Note that we're introducing some logic that will differ depending on the Desktop entry type (Application or Link). The logic is: - if entry is Application type, - then Exec is required - and the value is saved in .exec - and drun_mode_result calls exec_cmd_entry - if entry is Link type, - then URL is required (but is not saved in the DRunModeEntry) - and drun_mode_result calls new function launch_link_entry part of #1166 * [DRun] Launch desktop links via xdg-open Note that this introduces a new dependency on xdg-open, which may not be installed. In that case, rofi will display an error dialog with something like: "Failed to execute child process xdg-open (No such file or directory)" which hopefully is explanatory enough for folks. part of #1166 * Make drun options comments consistent and add a bit of whitespace * [DRun] new config option drun-url-launcher for opening links In previous commit, this was a hard-coded string. part of #1166
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
As per version 1.5 of the Desktop Entry Specification, an entry can be of
Type=Linkto point to a resource, but rofi (1.5.4-2, archlinux) doesn't display such entries when runningrofi -show drun.Example of such entry:
When reporting a feature request include the following information:
1.5.4The text was updated successfully, but these errors were encountered: