Add support for additional field on script entries meta
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this is to provide support for "hidden" fields on a script item that work for search but don't get displayed. This is mostly to provide something similar to the optional display (but still matchable) fields in drun like "categories" or "keywords". This also enables the choice to display unicode icons but still allow for searching for the keywords without needing to print them.
This fields provides a matchable but unprinted string for entries in a script mode list match. This means you can use one thing but provide multiple options that can match that item without polluting the list view or make confusing output.
|
Example utilization: https://gist.github.com/jdost/abbc3900e804d974777bbe62d299c4a0 |
|
Looks good. |
|
Thanks. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For some script mode usages and displays, the content is given additional information to help in finding the desired output (like with the
rofimojiandkaomoji rofiuser scripts). Since there is already a spec and support for adding icons, it seems sensible to add in a "meta" field for entries to provide matchable text but not include it in the primary entry field.Implementation
Following the same logic as used for parsing the
iconfield on an entry, an additionalmetafield is added and parsed out. This field is then used along with the primary entry content when doing token matching. This is similar in behavior to how thedrundialog works with matching things likekeywordorcategoryfor more contextual searching.