Support rasi config character type options #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the `xrm_Char` case in the (rasi theme) config file parser. This should properly handle configuration like ``` matching-negate-char: "\0"; ``` and ``` matching-negate-char: "-"; ```
`mem` shouldn't ever be set when `XrmOption` is `type` `xrm_Char`. Therefore, there is no need to check it and free it. Remove that logic.
...and missing period.
Add a `CHAR` token that takes things of the form `'<char>'` or some specific backslash escape sequences like `'\''` and `'\0'`. For now, save it as a `T_STRING`.
Instead of using strings for property elements of type char, use characters, which were recently added to the grammar.
Codecov Report
@@ Coverage Diff @@
## next #1131 +/- ##
==========================================
- Coverage 33.97% 33.96% -0.02%
==========================================
Files 40 40
Lines 11522 11531 +9
==========================================
+ Hits 3915 3916 +1
- Misses 7607 7615 +8
Continue to review full report at Codecov.
|
|
thanks. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to set
matching-negate-characterin a rasi config file,the following warning shows
This is because character types are not yet handled. Handle them from
the lexer all the way to xrm options. The format shall be single quotes
containing a single ASCII character (except newline) or certain escaped
character sequences, namely
\'\0\\