Port over dmenu flag '-selected-row' #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #909 +/- ##
==========================================
- Coverage 72.28% 72.28% -0.01%
==========================================
Files 39 39
Lines 10173 10176 +3
==========================================
+ Hits 7354 7356 +2
- Misses 2819 2820 +1
Continue to review full report at Codecov.
|
|
This has been in rofi for a while. thx. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38 people have resorted to xdotool hacks to skip to the second row on startup. Upon experimentation this seemed buggy for really fast alt tabs. This patch allows us to set the selected row using the
-selected-rowflag, just like in dmenu. Docs are incomplete so far, as I don't know where to document this. As I am also very unfamiliar with this code I have no clue if this addition is in a logical place.For now I named this argument the same as the dmenu equivalent that I found in the docs. I don't know if this is a good idea in terms of confusion.
Feedback is welcome.