Schedules to not take timezone into account

[mbyrne00]

Hi,

Regardless of what is entered into the timezone of a schedule, it seems to always kick off according to UTC.

The simplest fix is to change the following line

graphile-scheduler/sql/000001.sql

Line 89 in 06d73c9

IF :GRAPHILE_SCHEDULER_SCHEMA.schedules_matches(v_schedule, v_next_check) THEN

to the following ...

FROM

  	IF :GRAPHILE_SCHEDULER_SCHEMA.schedules_matches(v_schedule, v_next_check) THEN

TO

  	IF :GRAPHILE_SCHEDULER_SCHEMA.schedules_matches(v_schedule, v_next_check  AT TIME ZONE v_schedule.timezone) THEN

It would probably be better if the schedules_matches function itself could be passed any timestamp and did that translation internally but my PG plsql is very rusty.

Once I did the fix the schedules kicked off at the correct time. The job entries still had the fireDate specified in UTC time but it was the correct equivalent time.

[davbeck]

Oh man that's a pretty big oversight. To be clear, with that change, it worked as expected?

[mbyrne00]

Hey @davbeck - yes that quick fix did the trick. I can take a look at fixing the schedules_matches function instead of the quickfix and submitting a PR but can I please ask that you publish a new version after merging PR? We've had to keep using our own npm releases because the other merged PRs weren't released.

Otherwise we'd be happy to join as contributors to help speed things up.

[mbyrne00]

PR submitted ... tested locally with a bunch of crons and it fixes the issue. The PR does the update properly with a migration and fixes the schedules_matches function instead of the quick fix I did above. If you can please publish after merging that would be great.