Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content suffix support (RFC6839) #18

Merged
merged 1 commit into from Mar 3, 2018
Merged

Add content suffix support (RFC6839) #18

merged 1 commit into from Mar 3, 2018

Conversation

nvllsvm
Copy link
Contributor

@nvllsvm nvllsvm commented Mar 2, 2018

This adds support for parsing the content suffix from a subtype. A number of them are defined in RFC6839.

For example, application/vnd.test+json will be parsed to the following:

Type: application
Subtype: vnd.test
Suffix: json

@coveralls
Copy link

coveralls commented Mar 2, 2018

Coverage Status

Coverage decreased (-0.1%) to 99.217% when pulling 7d9e913 on nvllsvm:suffix into 532071c on dave-shawley:master.

@dave-shawley
Copy link
Owner

dave-shawley commented Mar 3, 2018

@nvllsvm +1 ... add yourself to AUTHORS.txt and I'll happily merge. I'll update the userland docs and release it shortly. Thanks for the contribution!

Actually ... I can do the updates. I'll have a new version up shortly. Are you going to add support to https://github.com/sprockets/sprockets.mixins.media_type as well? (nudge)(nudge)

@dave-shawley dave-shawley merged commit d549148 into dave-shawley:master Mar 3, 2018
@nvllsvm
Copy link
Contributor Author

nvllsvm commented Mar 3, 2018

@dave-shawley Thanks for the merge. I'll be taking care of that module along with https://github.com/sprockets/sprockets.mixins.http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants