This repository has been archived by the owner on Jan 11, 2018. It is now read-only.
Populate the label 'for' with the control id #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label 'for' attribute should reflect the id of the labelled control, not the name.
The population of the 'for' attribute for the label has been tied to the name field of the attached control. This has worked fine when using a simple property in the control expression, since the id and name are always equivalent, such as:
However if a complex expression is used, then the input 'id' must be sanitized, and the
name
must remain unsanitized so that the complex model can be model bound when posted. With the existing code the name is also sanitized, which breaks the default MVC model binding for complex properties.This change implements this correct behaviour for complex properties.