Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort headers intelligently #18

Closed
davecheney opened this issue Sep 24, 2016 · 1 comment
Closed

Sort headers intelligently #18

davecheney opened this issue Sep 24, 2016 · 1 comment

Comments

@davecheney
Copy link
Owner

From #16

I thought about this previously and have two suggestions.

  1. http headers are not sorted, they probably get unsorted more in this version compared to the python version because of the way maps work in Go vs whatever curl is doing.
  2. if we are going to sort headers, it shouldn't just be plain alpha sort, it should

I know this is more work, but I think this is only worth doing if it's done to this degree of precision.

@davecheney
Copy link
Owner Author

Note to implementors, ignore point 2a, this is the response, Host is not part of the response headers. This was my mistake.

davecheney added a commit that referenced this issue Sep 24, 2016
Fixes #18

Sort headers in a (roughly) stable manner. Server comes first, then the
end to end headers, then the hop by hop headers, each sorted
alphabetically.
@davecheney davecheney mentioned this issue Sep 24, 2016
davecheney added a commit that referenced this issue Sep 24, 2016
Fixes #18

Sort headers in a (roughly) stable manner. Server comes first, then the
end to end headers, then the hop by hop headers, each sorted
alphabetically.
amtrivedi91 added a commit to amtrivedi91/httpstat-go that referenced this issue Sep 27, 2016
Fixes davecheney#18

Sort headers in a (roughly) stable manner. Server comes first, then the
end to end headers, then the hop by hop headers, each sorted
alphabetically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant