Support Headers #34
Merged
Support Headers #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to re-use the `headers` type and add the 2 methods to support flag.Value
|
@freeformz looks like your test failed because of infuriating yaml shell escaping |
tcnksm
reviewed
Sep 25, 2016
| @@ -149,6 +159,9 @@ func visit(url *url.URL) { | |||
| if err != nil { | |||
| log.Fatalf("unable to create request: %v", err) | |||
| } | |||
| for _, h := range httpHeaders { | |||
| req.Header.Add(headerKeyValue(h)) | |||
There was a problem hiding this comment.
Hi, I came from #33 . Let's merge both features. Can you handle Host header here ? Host header can not be set via req.Header.Add. It needs to set via req.Host...
There was a problem hiding this comment.
I think this is ok, the host comes from the URL, see #36 for the -x flag that lets you send the request to a different iP.
This was referenced Sep 25, 2016
davecheney
added a commit
that referenced
this pull request
Sep 25, 2016
|
@freeformz @tcnksm in an effort to reduce the number of blocked PRs I'm going to resolve the conflicts and merge this change this evening. Please feel free to send followups/cleanups if there are things I've missed. |
amtrivedi91
added a commit
to amtrivedi91/httpstat-go
that referenced
this pull request
Sep 27, 2016
Updates davecheney#20 Updates davecheney#30 Updates davecheney#34 In an effort to reduce the number of merge conflicts, move reponse body processing into its own function. readResponseBody is responsible for consuming the response body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Decided to re-use the
headerstype and add the 2 methods to supportflag.Value