Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL parsing #79

Merged
merged 2 commits into from Sep 27, 2016
Merged

Fix URL parsing #79

merged 2 commits into from Sep 27, 2016

Conversation

moorereason
Copy link
Contributor

Get rid of schemify and let url.Parse do the heavy lifting.

Fixes #77 and replaces #78

Get rid of schemify and let url.Parse do the heavy lifting.
@op
Copy link

op commented Sep 27, 2016

@moorereason Yes, I like this better! I think the += "s" trick is harder to read than a simple if-else. ;)

@davecheney
Copy link
Owner

Thank you, that's much nicer.

@davecheney davecheney closed this Sep 27, 2016
@davecheney davecheney reopened this Sep 27, 2016
@davecheney davecheney merged commit c217740 into davecheney:master Sep 27, 2016
@moorereason moorereason deleted the iss77 branch October 1, 2016 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants