Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to get a decent speed-up for
pop()
without an extensive rewrite.Profiling
testPopPerformance()
shows that ~ 70% of the execution time forpop()
is taken up byMutableCollection.swapAt(_:_:)
and another ~ 13% isArray.subscript.getter
.Implementing the swap and the sink inside a call to
Array.withUnsafeMutableBufferPointer(_:)
gives a speedup of around 9x (on the release build) on my machine and puts the performance ofpop()
on a level withpush(_:)
andremove(_:)
.I think the performance gap must be a case of the compiler just not figuring out the optimization for
pop()
, since all of the other public functions which callsink(_:)
andswim(_:)
are plenty fast.