Use fsq filter for block so messages aren't opened

davedoesdev · Sep 10, 2016 · 081de08 · 081de08
1 parent d8fd4d2
commit 081de08
Show file tree

Hide file tree

Showing 9 changed files with 798 additions and 224 deletions.
diff --git a/README.md b/README.md
@@ -237,6 +237,7 @@ requests on attached [`MQlobberServer`](https://github.com/davedoesdev/mqlobber#
   - `{Object} [subscribe]` Allowed and disallowed topics for subscribe requests, with the following properties:
     - `{Array} [allow]` Clients can subscribe to messages published to these topics.
     - `{Array} [disallow]` Clients cannot subscribe to messages published to these topics.
+    - `{Boolean} [block]` Whether to prevent messages with topics matched by `disallow` being delivered to clients. This is useful if `allow` is a superset of `disallow` but you don't want messages matching `disallow` sent to clients. Defaults to `false`.
  
 Topics are the same as [`mqlobber` topics](https://github.com/davedoesdev/mqlobber#mqlobberclientprototypesubscribetopic-handler-cb) and [`qlobber-fsq` topics](
 https://github.com/davedoesdev/qlobber-fsq#qlobberfsqprototypesubscribetopic-handler-cb). They're split into words using `.` as the separator. You can use `*`
@@ -263,6 +264,9 @@ Access control is only applied where topics are specified.
 
 > Start applying access control to a [`MQlobberServer`](https://github.com/davedoesdev/mqlobber#mqlobberserverfsq-stream-options) object.
 
+You should only attach one `AccessControl` object to each `MQlobberServer`
+object. Attaching more than will result in unpredictable behaviour.
+
 **Parameters:**
 
 - `{MQlobberServer} server` Object to which to apply access control. The object's [`subscribe_requested`](https://github.com/davedoesdev/mqlobber#mqlobberservereventssubscribe_requestedtopic-cb) and [`publish_requested`](https://github.com/davedoesdev/mqlobber#mqlobberservereventspublish_requestedtopic-stream-options-cb) events will be handled in order to allow or disallow client requests according to the topic specifiers passed to [`AccessControl`](#accesscontroloptions) or[`reset`](#accesscontrolprototyperesetoptions).

diff --git a/coverage/coverage.json b/coverage/coverage.json
diff --git a/coverage/lcov-report/index.html b/coverage/lcov-report/index.html
@@ -22,22 +22,22 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>52/52</span>
+        <span class='fraction'>84/84</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>24/24</span>
+        <span class='fraction'>35/35</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Functions</span>
-        <span class='fraction'>10/10</span>
+        <span class='fraction'>11/11</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>52/52</span>
+        <span class='fraction'>84/84</span>
       </div>
     </div>
   </div>
@@ -62,13 +62,13 @@ <h1>
 	<td class="file high" data-value="mqlobber-access-control/"><a href="mqlobber-access-control/index.html">mqlobber-access-control/</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="52" class="abs high">52/52</td>
+	<td data-value="84" class="abs high">84/84</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="24" class="abs high">24/24</td>
+	<td data-value="35" class="abs high">35/35</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="10" class="abs high">10/10</td>
+	<td data-value="11" class="abs high">11/11</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="52" class="abs high">52/52</td>
+	<td data-value="84" class="abs high">84/84</td>
 	</tr>
 
 </tbody>
@@ -77,7 +77,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Sep 03 2016 14:28:53 GMT+0100 (BST)
+  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Sep 10 2016 08:00:50 GMT+0100 (BST)
 </div>
 </div>
 <script src="prettify.js"></script>

diff --git a/coverage/lcov-report/mqlobber-access-control/index.html b/coverage/lcov-report/mqlobber-access-control/index.html
@@ -22,22 +22,22 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>52/52</span>
+        <span class='fraction'>84/84</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>24/24</span>
+        <span class='fraction'>35/35</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Functions</span>
-        <span class='fraction'>10/10</span>
+        <span class='fraction'>11/11</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>52/52</span>
+        <span class='fraction'>84/84</span>
       </div>
     </div>
   </div>
@@ -62,13 +62,13 @@ <h1>
 	<td class="file high" data-value="index.js"><a href="index.js.html">index.js</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="52" class="abs high">52/52</td>
+	<td data-value="84" class="abs high">84/84</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="24" class="abs high">24/24</td>
+	<td data-value="35" class="abs high">35/35</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="10" class="abs high">10/10</td>
+	<td data-value="11" class="abs high">11/11</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="52" class="abs high">52/52</td>
+	<td data-value="84" class="abs high">84/84</td>
 	</tr>
 
 </tbody>
@@ -77,7 +77,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Sep 03 2016 14:28:53 GMT+0100 (BST)
+  generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Sep 10 2016 08:00:50 GMT+0100 (BST)
 </div>
 </div>
 <script src="../prettify.js"></script>