Skip to content

Commit

Permalink
Emit unsubscribe_all_requested when we unsubscribe on finish
Browse files Browse the repository at this point in the history
  • Loading branch information
@davedoesdev
davedoesdev committed Feb 1, 2017
1 parent 339a180 commit 3b3ecac
Show file tree
Hide file tree
Showing 11 changed files with 366 additions and 348 deletions.
2 changes: 1 addition & 1 deletion coverage/coverage.json
View file

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions coverage/lcov-report/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Statements</span>
<span class='fraction'>430/430</span>
<span class='fraction'>427/427</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Branches</span>
<span class='fraction'>220/220</span>
<span class='fraction'>216/216</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
Expand All @@ -37,7 +37,7 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Lines</span>
<span class='fraction'>429/429</span>
<span class='fraction'>427/427</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -75,13 +75,13 @@ <h1>
<td class="file high" data-value="mqlobber/lib/"><a href="mqlobber/lib/index.html">mqlobber/lib/</a></td>
<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
<td data-value="100" class="pct high">100%</td>
<td data-value="428" class="abs high">428/428</td>
<td data-value="425" class="abs high">425/425</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="220" class="abs high">220/220</td>
<td data-value="216" class="abs high">216/216</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="62" class="abs high">62/62</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="427" class="abs high">427/427</td>
<td data-value="425" class="abs high">425/425</td>
</tr>

</tbody>
Expand All @@ -90,7 +90,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/mqlobber/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/mqlobber/index.js.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/mqlobber/lib/client.js.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2479,7 +2479,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
14 changes: 7 additions & 7 deletions coverage/lcov-report/mqlobber/lib/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Statements</span>
<span class='fraction'>428/428</span>
<span class='fraction'>425/425</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Branches</span>
<span class='fraction'>220/220</span>
<span class='fraction'>216/216</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
Expand All @@ -37,7 +37,7 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Lines</span>
<span class='fraction'>427/427</span>
<span class='fraction'>425/425</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -75,13 +75,13 @@ <h1>
<td class="file high" data-value="server.js"><a href="server.js.html">server.js</a></td>
<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
<td data-value="100" class="pct high">100%</td>
<td data-value="209" class="abs high">209/209</td>
<td data-value="206" class="abs high">206/206</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="110" class="abs high">110/110</td>
<td data-value="106" class="abs high">106/106</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="32" class="abs high">32/32</td>
<td data-value="100" class="pct high">100%</td>
<td data-value="208" class="abs high">208/208</td>
<td data-value="206" class="abs high">206/206</td>
</tr>

</tbody>
Expand All @@ -90,7 +90,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
47 changes: 25 additions & 22 deletions coverage/lcov-report/mqlobber/lib/server.js.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Statements</span>
<span class='fraction'>209/209</span>
<span class='fraction'>206/206</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Branches</span>
<span class='fraction'>110/110</span>
<span class='fraction'>106/106</span>
</div>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
Expand All @@ -37,7 +37,7 @@ <h1>
<div class='fl pad1y space-right2'>
<span class="strong">100% </span>
<span class="quiet">Lines</span>
<span class='fraction'>208/208</span>
<span class='fraction'>206/206</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -625,7 +625,8 @@ <h1>
580
581
582
583</td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
583
584</td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -693,7 +694,7 @@ <h1>
<span class="cline-any cline-yes">1×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">23351×</span>
<span class="cline-any cline-yes">522086×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">89×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -731,8 +732,12 @@ <h1>
<span class="cline-any cline-yes">1904×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1904×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1904×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">2×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1904×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -945,9 +950,6 @@ <h1>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">61534×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">5108×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">61534×</span>
<span class="cline-any cline-yes">61534×</span>
<span class="cline-any cline-yes">61534×</span>
Expand Down Expand Up @@ -1093,9 +1095,9 @@ <h1>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">3616×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">4×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">2×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">4×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -1148,9 +1150,9 @@ <h1>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">538×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1906×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">2×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1906×</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -1275,7 +1277,7 @@ <h1>
function warning(err)
{
/*jshint validthis: true */
if (!ths.emit('warning', err, this))
if (err &amp;&amp; !ths.emit('warning', err, this))
{
console.error(err);
}
Expand Down Expand Up @@ -1312,8 +1314,12 @@ <h1>
&nbsp;
this.mux.on('finish', function ()
{
ths.unsubscribe();
ths._done = true;
&nbsp;
if (!ths.emit('unsubscribe_all_requested', warning))
{
ths.unsubscribe();
}
});
&nbsp;
this.relay_error = function (err)
Expand Down Expand Up @@ -1349,7 +1355,7 @@ <h1>
&nbsp;
function cb(err, cb2)
{
if (err) { warning(err); }
warning(err);
&nbsp;
if (!called)
{
Expand Down Expand Up @@ -1525,10 +1531,7 @@ <h1>
&nbsp;
function done(err, data)
{
if (err)
{
warning.call(duplex, err);
}
warning.call(duplex, err);
&nbsp;
var hdata = new Buffer(1);
hdata.writeUInt8(err ? 1 : 0);
Expand Down Expand Up @@ -1675,7 +1678,7 @@ <h1>
{
cb(err, n);
}
else if (err)
else
{
ths._warning(err);
}
Expand Down Expand Up @@ -1730,7 +1733,7 @@ <h1>
{
cb(err, n);
}
else if (err)
else
{
ths._warning(err);
}
Expand Down Expand Up @@ -1795,7 +1798,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jan 30 2017 22:09:15 GMT+0000 (GMT)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 01 2017 21:05:28 GMT+0000 (GMT)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
Loading

0 comments on commit 3b3ecac

Please sign in to comment.