Move remove undefined test into _remove_value

bench/options/_mapval.js

@@ -32,6 +32,7 @@ MapValQlobber.prototype._add_values = function (dest, origin)
 MapValQlobber.prototype._remove_value = function (vals, val)
 {
     vals.delete(val);
+    return vals.size === 0;
 };
 
 MapValQlobber.prototype.test_values = function (vals, val)

coverage/lcov-report/index.html

@@ -22,12 +22,12 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>170/170</span>
+        <span class='fraction'>174/174</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>95/95</span>
+        <span class='fraction'>98/98</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
@@ -37,7 +37,7 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>169/169</span>
+        <span class='fraction'>173/173</span>
       </div>
     </div>
   </div>
@@ -75,13 +75,13 @@ <h1>
 	<td class="file high" data-value="qlobber/lib"><a href="qlobber/lib/index.html">qlobber/lib</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="169" class="abs high">169/169</td>
+	<td data-value="173" class="abs high">173/173</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="95" class="abs high">95/95</td>
+	<td data-value="98" class="abs high">98/98</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="33" class="abs high">33/33</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="168" class="abs high">168/168</td>
+	<td data-value="172" class="abs high">172/172</td>
 	</tr>
 
 </tbody>
@@ -90,7 +90,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 07:48:47 GMT+0100 (BST)
+  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 22:26:44 GMT+0100 (BST)
 </div>
 </div>
 <script src="prettify.js"></script>

coverage/lcov-report/qlobber/index.html

@@ -77,7 +77,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 07:48:47 GMT+0100 (BST)
+  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 22:26:44 GMT+0100 (BST)
 </div>
 </div>
 <script src="../prettify.js"></script>

coverage/lcov-report/qlobber/index.js.html

@@ -58,7 +58,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 07:48:47 GMT+0100 (BST)
+  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 22:26:44 GMT+0100 (BST)
 </div>
 </div>
 <script src="../prettify.js"></script>

coverage/lcov-report/qlobber/lib/index.html

@@ -22,12 +22,12 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>169/169</span>
+        <span class='fraction'>173/173</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>95/95</span>
+        <span class='fraction'>98/98</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
@@ -37,7 +37,7 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>168/168</span>
+        <span class='fraction'>172/172</span>
       </div>
     </div>
   </div>
@@ -62,13 +62,13 @@ <h1>
 	<td class="file high" data-value="qlobber.js"><a href="qlobber.js.html">qlobber.js</a></td>
 	<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="169" class="abs high">169/169</td>
+	<td data-value="173" class="abs high">173/173</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="95" class="abs high">95/95</td>
+	<td data-value="98" class="abs high">98/98</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="33" class="abs high">33/33</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="168" class="abs high">168/168</td>
+	<td data-value="172" class="abs high">172/172</td>
 	</tr>
 
 </tbody>
@@ -77,7 +77,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 07:48:47 GMT+0100 (BST)
+  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 22:26:44 GMT+0100 (BST)
 </div>
 </div>
 <script src="../../prettify.js"></script>

coverage/lcov-report/qlobber/lib/qlobber.js.html

@@ -22,12 +22,12 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Statements</span>
-        <span class='fraction'>169/169</span>
+        <span class='fraction'>173/173</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Branches</span>
-        <span class='fraction'>95/95</span>
+        <span class='fraction'>98/98</span>
       </div>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
@@ -37,7 +37,7 @@ <h1>
       <div class='fl pad1y space-right2'>
         <span class="strong">100% </span>
         <span class="quiet">Lines</span>
-        <span class='fraction'>168/168</span>
+        <span class='fraction'>172/172</span>
       </div>
     </div>
   </div>
@@ -675,7 +675,15 @@ <h1>
 630
 631
 632
-633</td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
+633
+634
+635
+636
+637
+638
+639
+640
+641</td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -828,6 +836,11 @@ <h1>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">32x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">5x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">27x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">27x</span>
@@ -881,8 +894,6 @@ <h1>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">72x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">65x</span>
 <span class="cline-any cline-yes">65x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1214,6 +1225,11 @@ <h1>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">34x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">6x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">28x</span>
 <span class="cline-any cline-yes">28x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1272,7 +1288,7 @@ <h1>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">3x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1460,6 +1476,11 @@ <h1>
 &nbsp;
 Qlobber.prototype._remove_value = function (vals, val)
 {
+    if (val === undefined)
+    {
+        return true;
+    }
+&nbsp;
     var index = vals.lastIndexOf(val);
 &nbsp;
     if (index &gt;= 0)
@@ -1511,9 +1532,7 @@ <h1>
     {
         st = sub_trie.get(this._separator);
 &nbsp;
-        if (st &amp;&amp;
-            ((val === undefined) ||
-             this._remove_value(st, val)))
+        if (st &amp;&amp; this._remove_value(st, val))
         {
             sub_trie.delete(this._separator);
             return true;
@@ -1846,6 +1865,11 @@ <h1>
 &nbsp;
 QlobberDedup.prototype._remove_value = function (vals, val)
 {
+    if (val === undefined)
+    {
+        return true;
+    }
+&nbsp;
     vals.delete(val);
     return vals.size === 0;
 };
@@ -1945,7 +1969,7 @@ <h1>
 </div><!-- /wrapper -->
 <div class='footer quiet pad2 space-top1 center small'>
   Code coverage
-  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 07:48:47 GMT+0100 (BST)
+  generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Jul 31 2017 22:26:44 GMT+0100 (BST)
 </div>
 </div>
 <script src="../../prettify.js"></script>