Skip to content

Commit

Permalink
Tests on Travis fixed by upgrading boost
Browse files Browse the repository at this point in the history
  • Loading branch information
davedoesdev committed Nov 27, 2019
1 parent cd084dc commit e3574a7
Show file tree
Hide file tree
Showing 11 changed files with 34 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -10,4 +10,4 @@ before_install:
- sudo apt update
- sudo apt -y install libboost1.70-dev g++-9
script:
- npm run test
- if [ $TRAVIS_NODE_VERSION = 12 ]; then npm run coverage; else npm run test; fi
2 changes: 1 addition & 1 deletion coverage/lcov-report/index.html
Expand Up @@ -106,7 +106,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/qlobber/aedes/index.html
Expand Up @@ -80,7 +80,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/qlobber/aedes/qlobber-sub.js.html
Expand Up @@ -454,7 +454,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/qlobber/index.html
Expand Up @@ -80,7 +80,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/qlobber/index.js.html
Expand Up @@ -61,7 +61,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/qlobber/lib/index.html
Expand Up @@ -80,7 +80,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
26 changes: 13 additions & 13 deletions coverage/lcov-report/qlobber/lib/qlobber.js.html
Expand Up @@ -2071,18 +2071,18 @@ <h1>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">93x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-yes">94x</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
Expand Down Expand Up @@ -3280,7 +3280,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Mon Nov 25 2019 23:18:47 GMT+0000 (Greenwich Mean Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Nov 27 2019 07:45:06 GMT+0000 (Greenwich Mean Time)
</div>
</div>
<script src="../../prettify.js"></script>
Expand Down
26 changes: 13 additions & 13 deletions coverage/lcov.info
Expand Up @@ -210,7 +210,7 @@ FNDA:182,(anonymous_44)
FNDA:1,RestorerStream
FNDA:196,(anonymous_46)
FNDA:6,wrap_native
FNDA:93,(anonymous_48)
FNDA:94,(anonymous_48)
FNDA:24,(anonymous_49)
FNDA:2,(anonymous_50)
FNDA:40,(anonymous_51)
Expand Down Expand Up @@ -511,18 +511,18 @@ DA:937,1
DA:939,1
DA:941,196
DA:942,196
DA:950,93
DA:951,93
DA:952,93
DA:953,93
DA:954,93
DA:955,93
DA:956,93
DA:957,93
DA:958,93
DA:959,93
DA:960,93
DA:961,93
DA:950,94
DA:951,94
DA:952,94
DA:953,94
DA:954,94
DA:955,94
DA:956,94
DA:957,94
DA:958,94
DA:959,94
DA:960,94
DA:961,94
DA:966,24
DA:968,24
DA:970,3264
Expand Down
4 changes: 0 additions & 4 deletions src/qlobber_base.h
Expand Up @@ -11,8 +11,6 @@
#include "options.h"
#include "rwlock.h"

#include <iostream>

template <typename Value>
using VisitData = std::variant<std::string, Value>;

Expand Down Expand Up @@ -582,9 +580,7 @@ class QlobberBase {
throw std::length_error("too many wildcard somes");
}
words.push_back(word);
if (!adding) std::cerr << "NUM WORDS: " << words.size() << std::endl;
if (words.size() > options.max_words) {
std::cerr << "THROWING" << std::endl;
throw std::length_error("too many words");
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/topic.js
Expand Up @@ -518,7 +518,7 @@ describe(`qlobber (${type})`, function ()
expect(match('foo.#').sort()).to.eql(['it matched too!', 'it matched!']);
});

it.only('should throw exception for topics with many words', function () {
it('should throw exception for topics with many words', function () {
const topic = new Array(1000000).join('.');
expect(() => matcher.add(topic, 'foo'), 'add').to.throw('too many words');
expect(() => matcher.remove(topic, 'foo'), 'remove').to.throw('too many words');
Expand Down

0 comments on commit e3574a7

Please sign in to comment.