Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some scaladoc for the refinement package, along with a couple of convenience methods. #8

Conversation

Jacoby6000
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #8 into develop will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
+ Coverage    79.47%   79.73%   +0.26%     
===========================================
  Files           10       10              
  Lines          151      153       +2     
===========================================
+ Hits           120      122       +2     
  Misses          31       31
Impacted Files Coverage Δ
checklist/src/main/scala/checklist/Rule.scala 81.25% <ø> (ø) ⬆️
...n/scala/checklist/refinement/RuleHListSyntax.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879db26...792052c. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #8 into develop will increase coverage by 2.48%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
+ Coverage    79.47%   81.95%   +2.48%     
===========================================
  Files           10       13       +3     
  Lines          151      205      +54     
  Branches         0        2       +2     
===========================================
+ Hits           120      168      +48     
- Misses          31       37       +6
Impacted Files Coverage Δ
checklist/src/main/scala/checklist/Rule.scala 80.91% <ø> (-0.34%) ⬇️
...n/scala/checklist/refinement/RuleHListSyntax.scala 100% <100%> (ø) ⬆️
...list/src/main/scala/checklist/SizeableSyntax.scala 100% <0%> (ø)
checklist/src/main/scala/checklist/Sizeable.scala 100% <0%> (ø)
...ist/src/main/scala/checklist/IndexableSyntax.scala 66.66% <0%> (ø)
checklist/src/main/scala/checklist/Indexable.scala 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879db26...e575a50. Read the comment docs.

@Jacoby6000
Copy link
Collaborator Author

Hey @davegurnell, any way this can get merged in soon?

@davegurnell davegurnell merged commit e3235cd into davegurnell:develop Oct 31, 2017
@davegurnell
Copy link
Owner

Merged! Sorry for the delay.

@davegurnell
Copy link
Owner

Released as 0.4.0.

@davegurnell
Copy link
Owner

@Jacoby6000 I've also sent you a collaborator invite. It won't help with publishing to Sonatype but it will hopefully mitigate some of the long delays caused by me not being on top of things.

@Jacoby6000
Copy link
Collaborator Author

Jacoby6000 commented Oct 31, 2017

Cool deal! I'll hopefully not muddy things up too much 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants