Code cleanup and tunning #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved used interface and responsiveness - Removed delay on each current reading cycle - Enabled DEBUG define for printing messages to serial - Fixed detecting consecutive jams, halting and triggering alarm TODO: - Avoid changing direction too quickly - Enable user configuration of params: current offsets, start span - Circuit & PCB
Now using state machine Reverse time updated Fixed jamming time span Easier restarting after alarm Added handling for jam during reverse (just stop and try again)
TODO: calibrate and document calibration process
Defined variables for config Created macros for current conversion TODO: Allow serial configuration Avoid direction change before total halt
Using for cycle in startup banner Using external reference for AnalodRead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: