Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming "catches" on edges #148

Closed
pluscubed opened this issue Nov 10, 2015 · 5 comments
Closed

Zooming "catches" on edges #148

pluscubed opened this issue Nov 10, 2015 · 5 comments

Comments

@pluscubed
Copy link

Here's a video of what I'm talking about: https://youtu.be/to_BOMs7H2U

From my initial debugging, what appears to happen is that the predicted vTranslate coordinates in onTouchEvent() are off because of the centering in fitToBounds(), causing the vCenter coords to be off and the vTranslate coords to be corrected in fitToBounds() to that edge. This would explain why the further off the center, the worse the "catching" is.

@pluscubed pluscubed changed the title Zooming "" Zooming "catches" on edges Nov 10, 2015
@davemorrissey
Copy link
Owner

It has to be this way because the image should be centered in the dimension it doesn't fill. Otherwise when you zoom out you could leave the image off center. I don't plan to change this behaviour.

@pluscubed
Copy link
Author

Hmm... I suppose this is a question of whether to maintain the user's initial intended center (and "catch" to readjust because of the centering) or to change to the new apparent center as the photo's width/height becomes larger than the viewport. Google Photos takes the second approach so the zoom seems unaffected by the edge and more smooth.

@pluscubed
Copy link
Author

Google Photos appears to "catch" when zooming out to center the photo, but readjusts to the new center while zooming in so there's no catching.

@abhi385
Copy link

abhi385 commented Jul 15, 2016

how to make zooming with out limit.

@davemorrissey
Copy link
Owner

I've improved the behaviour in 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants