Skip to content

Commit

Permalink
🔨 Seems fish has an open command that does the RightThing(TM)
Browse files Browse the repository at this point in the history
So, let's make use of that in all situations.
  • Loading branch information
davep committed May 7, 2019
1 parent 76a0094 commit 7170775
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
3 changes: 3 additions & 0 deletions conf.d/aliases.fish
Expand Up @@ -6,4 +6,7 @@ alias vdir=dir
alias d=dir
alias v=vdir

# Be really lazy when opening things.
alias o=open

### aliases.fish ends here
2 changes: 1 addition & 1 deletion functions/gh.fish
Expand Up @@ -14,7 +14,7 @@ function gh -d "Visit the repo in its origin hub"
end

# Open in the browser.
o "https://"(string replace ":" "/" (string replace -r '\.git$' "" (string split "@" $origin)[ 2 ]))
open "https://"(string replace ":" "/" (string replace -r '\.git$' "" (string split "@" $origin)[ 2 ]))

end

Expand Down
15 changes: 0 additions & 15 deletions functions/o.fish

This file was deleted.

1 comment on commit 7170775

@davep
Copy link
Owner Author

@davep davep commented on 7170775 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to override the above a little bit with ed9b176 to solve a problem on some GNU/Linux boxen.

Please sign in to comment.