Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Config format is incorrect #15

Closed
davesag opened this issue Sep 19, 2018 · 0 comments
Closed

Migration Config format is incorrect #15

davesag opened this issue Sep 19, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@davesag
Copy link
Owner

davesag commented Sep 19, 2018

Currently we are emitting an object with format

{
  database,
  username,
  password,
  dialect,
  operatorsAliases,
  logging,
  options
  }

But according to https://github.com/sequelize/cli/blob/master/src/helpers/config-helper.js#L67

it ought to be

{
  database,
  username,
  password,
  dialect,
  host,
  port,
  operatorsAliases
}

The operatorAliases, logging and options are not needed for running migrations, and the host and port need to be top-level values, not injected into the options.

@davesag davesag added the bug Something isn't working label Sep 19, 2018
@davesag davesag self-assigned this Sep 19, 2018
davesag added a commit that referenced this issue Sep 19, 2018
davesag added a commit that referenced this issue Sep 19, 2018
davesag added a commit that referenced this issue Sep 19, 2018
davesag added a commit that referenced this issue Sep 19, 2018
@davesag davesag closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant