Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning: A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed. #35

Closed
davesag opened this issue May 3, 2019 · 4 comments
Closed

DeprecationWarning: A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed. #35

davesag opened this issue May 3, 2019 · 4 comments
Assignees
@davesag
Labels
enhancement New feature or request work in progress Someone is doing something about it
Milestone
Version 1.2.1

Comments

@davesag
Copy link
Owner

davesag commented May 3, 2019

Check for Sequelize v5 and don't pass in operatorsAliases option if detected.
@davesag davesag added the enhancement New feature or request label May 3, 2019
@davesag davesag added this to the Version 1.2.1 milestone May 3, 2019
@davesag davesag added the work in progress Someone is doing something about it label May 4, 2019
davesag added a commit that referenced this issue May 4, 2019
@davesag
#35 updated dependencies
f89e315
davesag added a commit that referenced this issue May 4, 2019
@davesag
#35 moved testHelper
4127007
davesag added a commit that referenced this issue May 4, 2019
@davesag
#35 remove operatorsAliases if not defined rather than default it to …
b494b11 
…false
davesag added a commit that referenced this issue May 4, 2019
@davesag
Merge pull request #37 from davesag/feature/35/remove-operator-aliase…
f7a486b 
…s-if-sequelize-v5

[feature, #35] remove operatorsAliases' default
@davesag davesag closed this as completed May 4, 2019
@hamedkaka
Copy link

hi
try
operatorsAliases: true,
on
operatorsAliases: 1,

@davesag davesag removed the work in progress Someone is doing something about it label Nov 27, 2019
@Imran-Haider313
Copy link

I don't think that's a solution. A better to handle it is This post

@davesag
Copy link
Owner Author

davesag commented Apr 18, 2020

I don't think that's a solution. A better to handle it is This post

Thanks I’ll take a look.

@davesag davesag reopened this Apr 18, 2020
@davesag davesag self-assigned this Apr 18, 2020
@davesag davesag added the work in progress Someone is doing something about it label Apr 25, 2020
@davesag
Copy link
Owner Author

davesag commented Apr 26, 2020

Having read through the latest version of the docs I have decided to remove the operatorsAliases option completely.

Deprecated: Operator Aliases

In Sequelize v4, it was possible to specify strings to refer to operators, instead of using Symbols. This is now deprecated and heavily discouraged, and will probably be removed in the next major version.

davesag added a commit that referenced this issue Apr 26, 2020
@davesag
#35 remove operatorsAliases
3c8cf60
davesag added a commit that referenced this issue Apr 26, 2020
@davesag
Merge pull request #82 from davesag/feature/35/operator-aliases-again
69789f7 
[feature, #35] remove operatorsAliases
@davesag davesag closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davesag davesag

Labels
enhancement New feature or request work in progress Someone is doing something about it
Projects
None yet
Milestone
Version 1.2.1
Development

No branches or pull requests
3 participants
@davesag @Imran-Haider313 @hamedkaka