Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic with incorrect info #163

Closed
hugoboos opened this issue Oct 31, 2022 · 2 comments
Closed

Panic with incorrect info #163

hugoboos opened this issue Oct 31, 2022 · 2 comments
Assignees
@daveshanley

Comments

@hugoboos
Copy link

Linting the following file causes a panic:

openapi: "3.1.0"
info: "test"
runtime error: index out of range [-1]

Caused by the info-description rule at https://github.com/daveshanley/vacuum/blob/main/functions/core/truthy.go#L57.

The node.Content being checked is empty.

Using the latest version with commit: 827bdef526f9afd954ffec54294753d1f29057a2
@daveshanley
Copy link
Owner

Nice catch! I'll investigate and patch ASAP.

@daveshanley daveshanley self-assigned this Oct 31, 2022
daveshanley added a commit that referenced this issue Oct 31, 2022
@daveshanley
(fix): Bugfix for issue #163
21ec45b 
The end node cannot be calculated if there is no content supplied (i.e. the wrong object type is passed in).

Signed-off-by: Dave Shanley <dave@quobix.com>
daveshanley added a commit that referenced this issue Oct 31, 2022
@daveshanley
(fix): Bugfix for issue #163
5d6135c 
The end node cannot be calculated if there is no content supplied (i.e. the wrong object type is passed in).

Signed-off-by: Dave Shanley <dave@quobix.com>
@daveshanley
Copy link
Owner

v0.0.36 has this issue resolved; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daveshanley daveshanley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveshanley @hugoboos