Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong command line silently fails #367

Closed
LasneF opened this issue Nov 15, 2023 · 4 comments
Closed

wrong command line silently fails #367

LasneF opened this issue Nov 15, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@LasneF
Copy link

LasneF commented Nov 15, 2023

when doing

vacuum --version

it just return nothing, should return invalid option and list the available flags

implementing an -version could be nice as well
@daveshanley daveshanley added the enhancement New feature or request label Nov 15, 2023
@ajoga
Copy link

ajoga commented Nov 17, 2023

I had a similar vibe when trying to configure --fail-severity to catch the messages that shows "hint" in the severity column: I'm not sure if it's a legal value for this key (nor if it should be).

So +1 on the idea of returning an error on invalid parameters, also consider returning and error on invalid values too ?

daveshanley added a commit that referenced this issue Nov 17, 2023
@daveshanley
Tuning up experience #361 #367 #334
a0ab9e9 
- Bad commands and flags are reported now
- Details view is cleaner and partially supports filepaths
- Misleading message about passing when using —fail-severity

Signed-off-by: quobix <dave@quobix.com>
@daveshanley daveshanley mentioned this issue Nov 17, 2023
Merged
daveshanley added a commit that referenced this issue Nov 18, 2023
@daveshanley
Tuning up experience #361 #367 #334
e78091f 
- Bad commands and flags are reported now
- Details view is cleaner and partially supports filepaths
- Misleading message about passing when using —fail-severity

Signed-off-by: quobix <dave@quobix.com>
@daveshanley
Copy link
Owner

Fixed in v0.5.0

Screenshot 2023-11-18 at 9 25 30 AM

@LasneF
Copy link
Author

LasneF commented Nov 20, 2023

good job ! one possible improvement would be to have the same banner as for wiretap

also common feature would be to display the version , or having a --version for the tools

@ajoga ajoga mentioned this issue Dec 5, 2023
Closed
@daveshanley
Copy link
Owner

a new version command will be available in v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daveshanley @LasneF @ajoga