feat: Docker related improvements #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the build image as the final one retains things in the image that's not needed at runtime, for example source code and build cache including dependencies. Additionally, the `golang:1.18` image contains the entire Go SDK as well as other software needed for building things, such as compilers etc, that are not needed at vacuum image runtime either. Use `debian:bullseye-slim` as the base image to fix both issues. Brings down size of the final image from 1.16GB to 107MB. We could conceivably use an even smaller base image for the final one than that, but we end up having some native lib dependencies in the binary; thus `scratch` as basis won't work. And as that's the case, it's safer to use the same basis as the `golang:1.18` build image does (it's currently based on Debian Bullseye) rather than jump to something completely different (such as e.g. Alpine based one).
Just `docker dshanley/vacuum lint` isn't enough, at least the OpenAPI spec needs to be mounted in the container for it to be available. Also, running a container off the image needs the `run` argument, and `--rm` is most likely what most people want. We now mount the base directory rather than just the top level spec file provides for finding referenced schemas in case they are in the same subdir tree. `/work` is set as the default working dir for the image, and is where the tree with the spec should be mounted at. While at it, consolidate/clarify instructions related to Docker Hub vs GHCR.
daveshanley
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.