refactor: change plugin/sample package to sample
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the conventional `go build ./...` and `go install ./...` work. With the sample in the `main` package currently: ```shellsession $ go build ./... runtime.main_main·f: function main is undeclared in the main package ``` Closes #135
|
There is no problem changing the package names, those plugins are designed specifically as samples anyway and are not to be used (as long as they compile, it's all good). I tested these changes and found no problems anywhere. Thank you for digging into this and for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the conventional
go build ./...andgo install ./...work. With the sample in themainpackage currently:Closes #135.
Warning: I didn't do any homework whatsoever with regards to vacuum plugins, so this might not be the right thing to do. If it's not, maybe it provokes another, proper fix :)