improve filter function

davesnx · Mar 28, 2024 · c31b1be · c31b1be
1 parent 640f237
commit c31b1be
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 16 deletions.
diff --git a/packages/css/js/Css_Js_Core.ml b/packages/css/js/Css_Js_Core.ml
@@ -1781,10 +1781,7 @@ let gridTemplateAreas l =
       | #Var.t as va -> Var.toString va
       | #Cascading.t as c -> Cascading.toString c )
 
-let filter x =
-  D
-    ( {js|filter|js},
-      x |. Std.Array.map Filter.toString |. Std.Array.joinWith ~sep:{js| |js} )
+let filter x = D ({js|filter|js}, Filter.filter x)
 
 module Shadow = struct
   type 'a value = string

diff --git a/packages/css/js/Css_Legacy_Core.ml b/packages/css/js/Css_Legacy_Core.ml
@@ -1663,10 +1663,7 @@ let gridTemplateAreas l =
       | #Var.t as va -> Var.toString va
       | #Cascading.t as c -> Cascading.toString c )
 
-let filter x =
-  D
-    ( {js|filter|js},
-      x |. Std.List.map Filter.toString |. Std.List.joinWith ~sep:{js| |js} )
+let filter x = D ({js|filter|js}, Filter.filter x)
 
 module Shadow = struct
   type 'a value = string

diff --git a/packages/css/native/Css_Js_Core.ml b/packages/css/native/Css_Js_Core.ml
@@ -1730,10 +1730,7 @@ let gridTemplateAreas l =
       | #Var.t as va -> Var.toString va
       | #Cascading.t as c -> Cascading.toString c )
 
-let filter x =
-  D
-    ( {js|filter|js},
-      x |. Std.Array.map Filter.toString |. Std.Array.joinWith ~sep:{js| |js} )
+let filter x = D ({js|filter|js}, Filter.filter x)
 
 module Shadow = struct
   type 'a value = string

diff --git a/packages/css/native/Css_Legacy_Core.ml b/packages/css/native/Css_Legacy_Core.ml
@@ -1618,10 +1618,7 @@ let gridTemplateAreas l =
       | #Var.t as va -> Var.toString va
       | #Cascading.t as c -> Cascading.toString c )
 
-let filter x =
-  D
-    ( {js|filter|js},
-      x |. Std.List.map Filter.toString |. Std.List.joinWith ~sep:{js| |js} )
+let filter x = D ({js|filter|js}, Filter.filter x)
 
 module Shadow = struct
   type 'a value = string

diff --git a/packages/css/native/shared/Css_AtomicTypes.ml b/packages/css/native/shared/Css_AtomicTypes.ml
@@ -2062,6 +2062,8 @@ module Filter = struct
     | #Url.t as u -> Url.toString u
     | #Var.t as va -> Var.toString va
     | #Cascading.t as c -> Cascading.toString c
+
+  let filter x = x |. Std.List.map toString |. Std.List.joinWith ~sep:{js| |js}
 end
 
 module BackgroundAttachment = struct

diff --git a/packages/css/native/shared/Css_AtomicTypes.mli b/packages/css/native/shared/Css_AtomicTypes.mli
@@ -1341,6 +1341,7 @@ module Filter : sig
     ]
 
   val toString : t -> string
+  val filter : t list -> string
 end
 
 module BackgroundAttachment : sig