Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a board needs a theme to work properly, warn that a theme is needed during code generation #183

Closed
davetcc opened this issue Feb 13, 2022 · 0 comments
Closed

When a board needs a theme to work properly, warn that a theme is needed during code generation #183

davetcc opened this issue Feb 13, 2022 · 0 comments
Assignees
@davetcc
Labels
display-tech enhancement New feature or request generator-ui Issues in Generator UI
Milestone
2.2.6

Comments

@davetcc
Copy link
Owner

davetcc commented Feb 13, 2022

Many people make the mistake of not selecting a theme, thinking that it is optional, in the next release absolutely ensure that a theme is selected if one is required.

This is a trivial change, essentially if the display plugin needs a theme, and one is not provided, present a dialog box indicating that rendering problems are likely if a theme is not selected.
@davetcc davetcc added enhancement New feature or request generator-ui Issues in Generator UI display-tech labels Feb 13, 2022
@davetcc davetcc added this to the 2.2.6 milestone Feb 13, 2022
@davetcc davetcc self-assigned this Feb 13, 2022
davetcc pushed a commit that referenced this issue Feb 15, 2022
#183 ensure theme is present when needed.
3178ccf 
#176 experimental web server in ESP
2.2.7 release
@davetcc davetcc closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davetcc davetcc

Labels
display-tech enhancement New feature or request generator-ui Issues in Generator UI
Projects
None yet
Milestone
2.2.6
Development

No branches or pull requests
1 participant
@davetcc