Added null as a valid value for RequestOptions.encoding
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required value to get a binary response (content is a Buffer) as explained in https://github.com/request/request/blob/master/README.md#requestoptions-callback (look for `encoding`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current "master" fails if
encoding: nullcompiling with TS2.0 with --strictNullChecks (?optional allows onlyundefined, notnull).When
encodingisnull, request returns a binary response (content is aBuffer): marking the field only as optional with?allowsundefined- which meansutf8- but not fornull(explained in https://github.com/request/request/blob/master/README.md#requestoptions-callback look forencoding).