Fix-up errors when viewing flight details if there are no custom flig…

…ht properties
davewalker5 · Mar 8, 2024 · a838b09 · a838b09
1 parent 4b107f3
commit a838b09
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 30 deletions.
diff --git a/src/DroneFlightLog.Mvc/Controllers/FlightDetailsController.cs b/src/DroneFlightLog.Mvc/Controllers/FlightDetailsController.cs
@@ -64,20 +64,23 @@ public async Task<IActionResult> Index(FlightDetailsViewModel model)
                 model.UpdatePropertiesFromBoundValues();
 
                 // Save newly added property values
-                for (int i = 0; i < model.Properties.Count; i++)
-                {
-                    FlightPropertyValue value = model.Properties[i];
-                    if (value.IsNewPropertyValue)
-                    {
-                        model.Properties[i] = await AddNewPropertyValueAsync(model.Id, model.Properties[i]);
-                    }
-                    else if (value.Id > 0)
-                    {
-                        model.Properties[i] = await _properties.UpdateFlightPropertyValueAsync(
-                                                                    value.Id,
-                                                                    value.NumberValue,
-                                                                    value.StringValue,
-                                                                    value.DateValue);
+                if (model.Properties?.Count > 0)
+                {
+                    for (int i = 0; i < model.Properties.Count; i++)
+                    {
+                        FlightPropertyValue value = model.Properties[i];
+                        if (value.IsNewPropertyValue)
+                        {
+                            model.Properties[i] = await AddNewPropertyValueAsync(model.Id, model.Properties[i]);
+                        }
+                        else if (value.Id > 0)
+                        {
+                            model.Properties[i] = await _properties.UpdateFlightPropertyValueAsync(
+                                                                        value.Id,
+                                                                        value.NumberValue,
+                                                                        value.StringValue,
+                                                                        value.DateValue);
+                        }
                     }
                 }
             }

diff --git a/src/DroneFlightLog.Mvc/Models/FlightDetailsViewModel.cs b/src/DroneFlightLog.Mvc/Models/FlightDetailsViewModel.cs
@@ -34,11 +34,11 @@ public void MergeProperties(List<FlightProperty> availableProperties)
             }
             else
             {
-                Properties = availableProperties.Select(m => new FlightPropertyValue { Property = m }).ToList();
+                Properties = availableProperties?.Select(m => new FlightPropertyValue { Property = m }).ToList();
             }
 
             // Sort the properties by name
-            Properties = Properties.OrderBy(p => p.Property.Name).ToList();
+            Properties = Properties?.OrderBy(p => p.Property.Name).ToList();
         }
 
         /// <summary>

diff --git a/src/DroneFlightLog.Mvc/Views/FlightDetails/Index.cshtml b/src/DroneFlightLog.Mvc/Views/FlightDetails/Index.cshtml
@@ -67,23 +67,26 @@
             </p>
             <hr />
 
-            @for (int i = 0; i < (Model.Properties.Count / Model.PropertiesPerRow) + 1; i++)
+            @if (Model.Properties != null)
             {
-                <div class="row">
-                    @for (int j = 0; j < Model.PropertiesPerRow; j++)
-                    {
-                        int index = i * Model.PropertiesPerRow + j;
-                        if (index < Model.Properties.Count)
+                for (int i = 0; i < (Model.Properties.Count / Model.PropertiesPerRow) + 1; i++)
+                {
+                    <div class="row">
+                        @for (int j = 0; j < Model.PropertiesPerRow; j++)
                         {
-                            @await Html.PartialAsync("../Shared/FlightPropertyValue", Model.Properties[index]);
+                            int index = i * Model.PropertiesPerRow + j;
+                            if (index < Model.Properties.Count)
+                            {
+                                @await Html.PartialAsync("../Shared/FlightPropertyValue", Model.Properties[index]);
+                            }
+                            else
+                            {
+                                <div class="col"></div>
+                            }
                         }
-                        else
-                        {
-                            <div class="col"></div>
-                        }
-                    }
-                </div>
-                <br />
+                    </div>
+                    <br />
+                }
             }
 
             <hr />