Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #6

Merged
merged 1 commit into from Jun 22, 2016
Merged

Update index.js #6

merged 1 commit into from Jun 22, 2016

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Jun 22, 2016

I believe we actually only want to recompute the cache if the favicon itself changes, without this we will rebuild for an input change. It may also be a good idea to have some sort of persistent cache, so initial boots aren't also so slow.

@davewasmer
Copy link
Owner

Ah didn't realize caching writer would use inputPaths to determine when the cache was busted.

As for the persistent cache, I'd love to, but broccoli-persistent-filter doesn't seem to support 1:N trees. See my comment on your issue.

@davewasmer davewasmer merged commit c3ca428 into davewasmer:master Jun 22, 2016
@stefanpenner
Copy link
Contributor Author

@davewasmer you should be able to add a persistent cache to anything even broccoli-caching-writer, ultimately persistent-filter just delegates to https://github.com/stefanpenner/async-disk-cache

@stefanpenner
Copy link
Contributor Author

stefanpenner commented Jun 22, 2016

basically: build a cache key based on filePath + config + misc other stuff that might need to be around here: https://github.com/davewasmer/broccoli-favicon/blob/master/index.js#L59 then use https://github.com/stefanpenner/async-disk-cache.

The primitives aren't the best yet, but it should still be possible.

@stefanpenner stefanpenner deleted the patch-1 branch April 3, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants