forked from llvm/llvm-project
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AMDGPU: Fix verifier error on killed spill of partially undef register
This does unfortunately end up with extra waitcnts getting inserted that were avoided before. Ideally we would avoid the spills of these undef components in the first place.
- Loading branch information
Showing
6 changed files
with
233 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -verify-machineinstrs -run-pass=prologepilog %s -o - | FileCheck -check-prefix=CHECK -check-prefix=GFX908 %s | ||
|
||
--- | ||
name: spill_a64_kill | ||
tracksRegLiveness: true | ||
stack: | ||
- { id: 0, type: spill-slot, size: 8, alignment: 4 } | ||
machineFunctionInfo: | ||
scratchRSrcReg: '$sgpr0_sgpr1_sgpr2_sgpr3' | ||
stackPtrOffsetReg: '$sgpr32' | ||
frameOffsetReg: '$sgpr33' | ||
body: | | ||
bb.0: | ||
liveins: $agpr0_agpr1 | ||
; CHECK-LABEL: name: spill_a64_kill | ||
; CHECK: liveins: $agpr0_agpr1 | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr0, implicit $exec, implicit-def $agpr0_agpr1 | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, 0, 0, 0, implicit $exec, implicit $agpr0_agpr1 :: (store 4 into %stack.0, addrspace 5) | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr1, implicit $exec | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, 0, 0, 0, implicit $exec, implicit killed $agpr0_agpr1 :: (store 4 into %stack.0 + 4, addrspace 5) | ||
SI_SPILL_A64_SAVE killed $agpr0_agpr1, %stack.0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, implicit $exec :: (store 8 into %stack.0, addrspace 5) | ||
... | ||
|
||
# Make sure there's no verifier error on the undef spill component when the value is killed. | ||
|
||
--- | ||
name: spill_a64_undef_sub1_killed | ||
tracksRegLiveness: true | ||
stack: | ||
- { id: 0, type: spill-slot, size: 8, alignment: 4 } | ||
machineFunctionInfo: | ||
scratchRSrcReg: '$sgpr0_sgpr1_sgpr2_sgpr3' | ||
stackPtrOffsetReg: '$sgpr32' | ||
frameOffsetReg: '$sgpr33' | ||
body: | | ||
bb.0: | ||
liveins: $agpr0 | ||
; CHECK-LABEL: name: spill_a64_undef_sub1_killed | ||
; CHECK: liveins: $agpr0 | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr0, implicit $exec, implicit-def $agpr0_agpr1 | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, 0, 0, 0, implicit $exec, implicit $agpr0_agpr1 :: (store 4 into %stack.0, addrspace 5) | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr1, implicit $exec | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, 0, 0, 0, implicit $exec, implicit killed $agpr0_agpr1 :: (store 4 into %stack.0 + 4, addrspace 5) | ||
SI_SPILL_A64_SAVE killed $agpr0_agpr1, %stack.0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, implicit $exec :: (store 8 into %stack.0, addrspace 5) | ||
... | ||
|
||
--- | ||
name: spill_a64_undef_sub0_killed | ||
tracksRegLiveness: true | ||
stack: | ||
- { id: 0, type: spill-slot, size: 8, alignment: 4 } | ||
machineFunctionInfo: | ||
scratchRSrcReg: '$sgpr0_sgpr1_sgpr2_sgpr3' | ||
stackPtrOffsetReg: '$sgpr32' | ||
frameOffsetReg: '$sgpr33' | ||
body: | | ||
bb.0: | ||
liveins: $agpr1 | ||
; CHECK-LABEL: name: spill_a64_undef_sub0_killed | ||
; CHECK: liveins: $agpr1 | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr0, implicit $exec, implicit-def $agpr0_agpr1 | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, 0, 0, 0, implicit $exec, implicit $agpr0_agpr1 :: (store 4 into %stack.0, addrspace 5) | ||
; CHECK: $vgpr0 = V_ACCVGPR_READ_B32 killed $agpr1, implicit $exec | ||
; CHECK: BUFFER_STORE_DWORD_OFFSET killed $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, 0, 0, 0, implicit $exec, implicit killed $agpr0_agpr1 :: (store 4 into %stack.0 + 4, addrspace 5) | ||
SI_SPILL_A64_SAVE killed $agpr0_agpr1, %stack.0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, implicit $exec :: (store 8 into %stack.0, addrspace 5) | ||
... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.