Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 5m timeout #35

Merged
merged 3 commits into from Oct 12, 2018
Merged

add 5m timeout #35

merged 3 commits into from Oct 12, 2018

Conversation

mrose17
Copy link
Collaborator

@mrose17 mrose17 commented Oct 11, 2018 •
edited

after rebase!

@davglass
Copy link
Owner

@mrose17 I sent you a PR with some tweaks for this: homespun/doorbot#1

@mrose17
Merge pull request #1 from davglass/homespun-master
7728bc0 
Refactored timeout and added test
@mrose17
Copy link
Collaborator Author

mrose17 commented Oct 12, 2018

thanks. looks good. merged.

@davglass davglass merged commit d8cd680 into davglass:master Oct 12, 2018
@davglass
Copy link
Owner

@mrose17 Do you need a release cut on this or are you still working on something?

@mrose17
Copy link
Collaborator Author

mrose17 commented Oct 12, 2018

it would be good to cut a release (this weekend would be fine... thanks for checking!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davglass davglass davglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrose17 @davglass