chore: update to rxjs 6 and axios 0.18 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: .travis.yml
* updated build to use Axios 0.18.0
modified: README.md
* added RxJS 6 note
modified: package-lock.json
modified: package.json
* updated RxJS to ^6.0.0
* udapted Axios to 0.18.0
* updated dev dependencies
modified: src/index.ts
* changes required for RxJS 6 API (import)
BREAKING CHANGE: peer dependency on RxJS 6
|
Since I need this functionality too I fork the repo and apply this PR and @tentenponce one in https://github.com/karlos1337/rxios , glad to remove it when @davguij apply the PR's here. |
correct syntax for advanced usage for RxJS 6
|
@davguij do you have any feedback for this pull request, or should i close? |
|
Will you guys be cutting a release for this anytime soon? Thanks :D |
|
Sorry for so much time without any updates from my side. v2.0.0 should fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see there is a pull request open for RxJS 6 Alpha with conflicts, thought I would submit a PR for RxJS 6 now it is released.
Have bumped peer dependancies to Axios 0.18.0 and RxJS 6 also update the dev dependancies while I was at it.
All tests passing, comments welcome!
Thanks,
Mark