Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Makie, CairoMakie and Plots as requirements via Requires.jl #8

Merged
merged 6 commits into from
Jan 8, 2022

Conversation

davibarreira
Copy link
Owner

This PR moves some code around in order to improve the organization overall. It also fixes some small bugs:

  • It recognizes the text/plain output in Jupyter cells;
  • It does not return the subsubsubsection, which does not exists. Instead, it just uses \textbf.

The main change comes from the fact that now it uses Requires.jl in order to avoid Makie, CairoMakie and Plots as dependencies. Theses packages are only necessary for the Pluto converter. Hence, if you just wish to convert Jupyter notebooks, the package precompilation time will be quite low.

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #8 (ed36262) into master (8e25d91) will increase coverage by 0.05%.
The diff coverage is 98.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   96.81%   96.86%   +0.05%     
==========================================
  Files           5        7       +2     
  Lines         408      415       +7     
==========================================
+ Hits          395      402       +7     
  Misses         13       13              
Impacted Files Coverage Δ
src/markdowntolatex.jl 99.17% <0.00%> (ø)
src/plutoconverter.jl 99.13% <99.13%> (ø)
src/NotebookToLaTeX.jl 90.90% <100.00%> (-8.00%) ⬇️
src/jupyterconverter.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e25d91...ed36262. Read the comment docs.

@davibarreira davibarreira merged commit 27ffe4d into master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant