fixed dimensions in adding new users

david-cortes · Aug 4, 2018 · 686e7aa · 686e7aa
1 parent 695a6b1
commit 686e7aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/hpfrec/__init__.py b/hpfrec/__init__.py
@@ -685,7 +685,7 @@ def partial_fit(self, counts_df, step_size=None, nusers=None, nitems=None,
         if random_seed is not None:
             if isinstance(random_seed, float):
                 random_seed = int(random_seed)
-        assert isinstance(random_seed, int)
+            assert isinstance(random_seed, int)
 
         if counts_df.__class__.__name__ == "ndarray":
             counts_df = pd.DataFrame(counts_df)
@@ -983,7 +983,8 @@ def add_user(self, user_id, counts_df, update_existing=False, maxiter=10, ncores
                 if self.keep_all_objs:
                     self.Gamma_shp[user_id] = temp[0]
                     self.Gamma_rte[user_id] = temp[1]
-                    self.k_rte[user_id] = self.a_prime/self.b_prime + (temp[0]/temp[1]).sum(axis=1, keepdims=True)
+                    self.k_rte[user_id] = self.a_prime/self.b_prime + \
+                                        (temp[0].reshape((1,-1))/temp[1].reshape((1,-1))).sum(axis=1, keepdims=True)
             else:
                 if self.reindex:
                     new_id = self.user_mapping_.shape[0]
@@ -994,7 +995,8 @@ def add_user(self, user_id, counts_df, update_existing=False, maxiter=10, ncores
                 if self.keep_all_objs:
                     self.Gamma_shp = np.r_[self.Gamma_shp, temp[0].reshape((1, self.k))]
                     self.Gamma_rte = np.r_[self.Gamma_rte, temp[1].reshape((1, self.k))]
-                    self.k_rte = np.r_[self.k_rte, self.a_prime/self.b_prime + (temp[0]/temp[1]).sum(axis=1, keepdims=True)]
+                    self.k_rte = np.r_[self.k_rte, self.a_prime/self.b_prime + \
+                                    (temp[0].reshape((1,-1))/temp[1].reshape((1,-1))).sum(axis=1, keepdims=True)]
                 self.nusers += 1
 
         ## updating the list of seen items for this user

diff --git a/setup.py b/setup.py
@@ -27,7 +27,7 @@
    'scipy',
    'cython'
 ],
-  version = '0.2.1',
+  version = '0.2.1.1',
   description = 'Hierarchical Poisson matrix factorization for recommender systems',
   author = 'David Cortes',
   author_email = 'david.cortes.rivera@gmail.com',