Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findSeparator's character list (low priority) #1063

Closed
elwinmartin opened this issue Sep 7, 2016 · 2 comments
Closed

findSeparator's character list (low priority) #1063

elwinmartin opened this issue Sep 7, 2016 · 2 comments
Labels
connector This issue or pull request is related to connectors feature New feature or request

Comments

@elwinmartin
Copy link

Hey,

I was just wondering why '/' wasn't a default separator but '///' is for the Youtube connector?

Is this just not as common, or does this conflict with some titles commonly scrobbled (for example artists who have a single '/' in their name?

I'm trying to fix some of the issues that I've had with scrobbling Japanese music videos, which often use a naming convention that doesn't really mesh well with the defaults.

@inverse inverse added feature New feature or request connector This issue or pull request is related to connectors labels Sep 26, 2016
@inverse
Copy link
Member

inverse commented Sep 26, 2016

We should ideally allow the input of custom separators so people can customise the scrobbler to their liking.

@alexesprit
Copy link
Member

Is this just not as common, or does this conflict with some titles commonly scrobbled (for example artists who have a single '/' in their name?

I've added '/' symbol in the end of list of separators, so there should be no conflicts with artist names or song titles (e.g. https://www.youtube.com/watch?v=HG6b9GjLhtU). The only thing is the extension now recognizes Youtube titles like "XXX/YYY" where XXX and YYY are random strings, but I don't think it's a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector This issue or pull request is related to connectors feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants