Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hornor release and target options for non-incremental compile #586

Merged
merged 1 commit into from Apr 3, 2022
Merged

hornor release and target options for non-incremental compile #586

merged 1 commit into from Apr 3, 2022

Conversation

gzm55
Copy link
Contributor

@gzm55 gzm55 commented Mar 25, 2022

fix #584 and #585

@gzm55
Copy link
Contributor Author

gzm55 commented Mar 28, 2022

@davidB @slandelle could you plz review this pr?

davidB
davidB approved these changes Apr 3, 2022
View reviewed changes
Copy link
Owner

@davidB davidB left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@davidB davidB merged commit 627772b into davidB:master Apr 3, 2022
@slandelle
Copy link
Collaborator

Sorry for the delay.
It would have been nice to add some tests, like I did for 36453a1

@gzm55 gzm55 mentioned this pull request Apr 4, 2022
Open
@gzm55
Copy link
Contributor Author

gzm55 commented Apr 4, 2022

Sorry for the delay. It would have been nice to add some tests, like I did for 36453a1

thanks, some ut for this pr are added in #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidB davidB davidB approved these changes

@slandelle slandelle Awaiting requested review from slandelle slandelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maven.compiler.target does not take effect when recompileMode is all
3 participants
@gzm55 @slandelle @davidB