Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Apple Silicon. #1

Merged
merged 2 commits into from Dec 22, 2021

Conversation

stanislas
Copy link

Hi,

I have updated the project to compile for x86_64 and arm64 (Apple Silicon).

I have also updated to Gradle 7.3.1 and removed all deprecations warnings for a future update to Gradle 8. I have not updated any of the publication part; i guess that the change to Gradle 7.3.1 will require some changes there too.

However, I managed to compile, test and install locally on my MacBook Pro with M1Pro. It works like a charm.

What do you think?

@davidafsilva
Copy link
Owner

Hey @stanislas,

Thank you very much for the update and sorry for the late reply, the last weeks have been quite interesting to say the least, specially the last one (log4shell).

I will take a look in a bit. Unfortunately i skipped the first generation of M1s and I'm still waiting for my MBP to arrive, so I can't really test this.

Copy link
Owner

@davidafsilva davidafsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! 👍

Left a couple of comments which I can certainly have a look if you don't want to. Let know what you think.
I can't really test this right now on an arm64 but I'm fine if you did.

I'll need to update the publishing though, as it is targeting Bintray I believe.

build.gradle Show resolved Hide resolved
build.gradle Show resolved Hide resolved
@davidafsilva
Copy link
Owner

Hey Stanislas,

If you don't mind, I'm going to merge this and try to rework the Gradle scripts, specially the publishing bits as I'll need move the packages to OSSRH (maven-central).

Thanks!

@davidafsilva davidafsilva merged commit 606d4c3 into davidafsilva:master Dec 22, 2021
@stanislas
Copy link
Author

Hey David,
Sorry for the late answer. I was away from the computer.

Thank you so much for fixing the merge request and teaching me some gradle.

I tested the version 1.1.0 on my M1Pro machine and it works fine. Thank you!

@davidafsilva
Copy link
Owner

No problem.
Thank you for the contribution once again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants