Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct socket path for linux #334

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

alinalexandru
Copy link
Contributor

Fixes #331

I explained in ticket the reason to set the SSH_AUTH_SOCK environment variable

@ihor-sviziev
Copy link
Contributor

Hi @alinalexandru,
I believe it won't work correctly in case if your user id on the host machine not equal to 1000.
Here are more details about that: #307 (comment) #307 (comment)

@alinalexandru
Copy link
Contributor Author

You are right with the user id.
The issue with user with ID 1000 still exists. This week I had to change the user ID to 1000 so that I could fix the composer/cache permissions.

Don't know if there could be done a user id check in entry point.
For us at the moment, this hack is working, as we all have User ID 1000.

@ihor-sviziev
Copy link
Contributor

@alinalexandru maybe we can introduce a new variable that will be set similar to this?
https://github.com/davidalger/warden/blob/5d1843bca3f6ed0ebc8615d651db4bc57765bb91/commands/env.cmd#L46-L49

@alinalexandru
Copy link
Contributor Author

That it's a good ideea, it might solve this issue for most of the linux users.

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your solution with suggested in comments changes?

@alinalexandru
Copy link
Contributor Author

Yes, I will work on that today.

@springerin
Copy link

Any updates on when this can be release?

Great job @alinalexandru for the debug. Thank you very much, i am having this issue very often now and couldn't figure out what was happening.

@ihor-sviziev
Copy link
Contributor

@davidalger could you review this PR?

@davidalger
Copy link
Collaborator

LG2M as well. Thanks for the efforts at guiding this one @ihor-sviziev. Going to merge it, and once I have a chance to verify on my Linux box over here and update the CL will tag a release.

@davidalger davidalger merged commit 26f5e92 into wardenenv:develop Apr 2, 2021
davidalger added a commit that referenced this pull request Apr 2, 2021
@davidalger davidalger added this to the Warden 0.10.2 milestone Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Agent freezes sometimes
4 participants