-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further suggestions & future plans #28
Comments
Yeah i agree with you, but maybe is a little bit too overkill to use react on this project haha. But we could try to at least improve that templating part. I would like to know the way you are thinking to implement the notification system. Thanks for all the design and functions you did. Now it's more usable. P.S: sorry for the late answer im a little bit bussy lately. |
Alright, then I'll look into the "CSS in JS" option.
Basically, the general idea I have is using Github's workflows. This could be set up in a way that will send an email or a message via the Telegram bot or any other way probably.
It's fine :) |
But this will not work i think. You will need to log in from a different ip, use the 2FA etc etc.. Instagram will see a strange ip login. And could get ban. (Maybe im not understanding how github workflow works. Correct me if im wrong.). The css on js option sound good to me. |
Yeah it's definitely not easy. But it's an idea 🤷🏼♂️
👍🏼 |
I would first implement the css in js and then we could think about the notification system. Its a bit more complex to do i think. |
Hi, i wanted to thank everyone who worked on this amazing tool, i really like it By the way i want to make a suggestion: it would be great if there was an option to exclude a list of users, like a whitelist or something like that. (because i have a bunch of pages that i follow that doesn't have the blue thing so everytime i have to select manually who to follow rather than just using select everyone). |
@onnipotenza Nice idea! |
Hey @davidarroyo1234 |
mm nop, i didnt change anything. I'll check if github has done some changes. Can you post a photo of the error? |
TODO list:
Leaving this here as a reminder for myself. Not sure when I'll get around to this, but I do believe it will be added. |
Hello folks! Thanks for creating and supporting an excellent tool as an alternative to AppStore trash with a huge number of ads. |
I have consider doing it, but I dont know if violates some chrome store rules or some law. Also is not as "transparent" for a user. Here you can see all the code that is being use. I could create a downloadable chrome extension in the repo and then if someone wants it could import itself. |
Sounds great to me, thanks! |
@davidarroyo1234 Wanted to get your thoughts on something. JSX is a much nicer way of combining HTML with JS then what we currently have, and it will make some stuff a lot cleaner. I've played around with it a bit and it seems to work just fine. Wanted to know WDYT about this change and how comfortable you are with JSX. |
Hello, I notice that the unfollower list json come in chronological order: First item=most recent; last item=the earliest user you followed. |
I usually use angular so im not used to jsx. But we could try it. We should not make a very large code to copy. |
I will take a note for a future sort option. Thanks! |
It shouldn't enlarge the code IIRC, as the babel simply compiles everything to regular JS at build. |
Okay, thanks @tomleb3! |
hello I have a few suggestions.
instead of a framework, I'd like to recommend the use of a template engine like handlebars. this should lead to a smaller code size as well because libraries like react and vue require virtual doms which increases the size by a lot.
can you please look into turning it into a chrome extension, I think that should make the script much more user-friendly. If I get time ill try to implement these changes and make a PR. |
Hey @eshdownbad ! As for the framework discussion, we've decided not to go with it, as it is overkill in this case. I am not familiar with Handlebars but it definitely sounds interesting. |
BTW I toyed around with using JSX without React like I've mentioned before. My main issue, as I've mentioned before, is that the manual DOM manipulation is very janky and difficult to keep track of. Tried "Handlebars" like the user above suggested, but didn't feel comfortable enough with it. If we eventually would like to incorporate a framework, then 2 good options IMO are: Wanted to know if you have any thoughts on this. |
@tomleb3 Preact sounds good, if you can recreate a minimal example to inject in chrome i would appreciate it. (some html code and state change or something) |
Definitely. I'll start working on it in my spare time. |
Hey @davidarroyo1234 ! Also, I see that you made all fields optional, is it supposed to be that way? |
There is not documentation for the types of user.. It's manually done, using the chrome devtool on the network tab. Then grab the response when you click on the follower list. With the response you can write the model manually or use some online/offline mapper. I made the fields optional because i don't know if instagram will send me every time this values. |
OK, I think we can assume them to be non-optional until proven otherwise. |
I mean, all the values should come from the api, but its not 100% sure... |
True, technically we can't rely on them being there. So it leaves us with 2 options. Let me know your thoughts on this. |
I think this option is better. Because at least you will know if they always exits or not. |
I think it's time to close this issue. |
Yep, Good job. If someone else has any other idea open a issue or discussion. God joob @tomleb3 |
Thanks @davidarroyo1234 ! |
Hey @davidarroyo1234 👋🏼
Hope all is well with you.
First of, let me just say that I've enjoyed working on this tool, and thanks for adding me as a collaborator.
Ultimately I think the result came out good, the script was already very useful and now has a nice UI and everything.
I'd like to open a short discussion and get your thoughts on some stuff.
Currently, the weak point of the script IMO is the HTML template strings.
I used them since they we're the simpler option at the time, but they are bulky and difficult to read, which makes it harder not only for us, but also for new devs who would like to contribute and don't know the code.
Also, the more stuff we add, the messier it will get.
This is something that I would like to improve and be happy to take upon myself to work on whenever I have some spare time.
I would mainly like to discuss options for this and find out what you'll feel more comfortable with.
Here are some options that come to mind:
However, although some of these frameworks are very popular now, the main downside of using it is that their popularity will likely not last forever, unlike vanilla JS, which will probably still be used after humans colonize Mars 😆
Anyway, just some thoughts.
Please let me know which ideas you feel comfortable with, if any.
Also if you have any other ideas, I'm open for them.
P.S. - I actually have an idea of how to implement the unfollow-notification idea that was suggested in one of the issues.
And even relatively within the context of the script. Sort of.
But that's a conversation for another day.
Thanks again,
Tom.
The text was updated successfully, but these errors were encountered: