Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes name collision between hclust.jl and HClust.jl in OSX checkout process #1

Merged
merged 2 commits into from
Jun 23, 2015

Conversation

slundberg
Copy link
Contributor

hclust.jl overwrites HClust.jl when doing a package install on OSX. This fixes that by renaming hclust.jl to hclust_impl.jl and allows the package to work on OSX.

@davidavdav davidavdav merged commit fc9da11 into davidavdav:master Jun 23, 2015
@davidavdav
Copy link
Owner

See this rant, to which I wholeheartedly agree. This policy recently costed me a day reinstalling a new mac, and caused me to lose backup history on two independent backups.

BTW I have a pull request to include this in Clustering, but it seems kind-of dead. No clue what will happen to it.

@slundberg
Copy link
Contributor Author

I agree a case insensitive FS is a mistake for OSX. As for the pull request, you have this code as GPLv2 and Clustering is under MIT, it might make sense to have this at MIT as well to allows things to be merged.

@slundberg
Copy link
Contributor Author

BTW. Nice package. I was glad to find a pure Julia version of hierarchical clustering so I could share code using clustering without requiring R or Python integration installed.

@davidavdav
Copy link
Owner

I submitted a PR to a MIT package so I assume that the code in the PR
automatically becomes MIT licensed.

---david

sent from a mobile Linux os.
Op 23 jun. 2015 17:28 schreef "Scott Lundberg" notifications@github.com:

I agree a case insensitive FS is a mistake for OSX. As for the pull
request, you have this code as GPLv2 and Clustering is under MIT, it might
make sense to have this at MIT as well to allows things to be merged.


Reply to this email directly or view it on GitHub
#1 (comment).

@slundberg
Copy link
Contributor Author

Makes sense, given you are the sole author.

@davidavdav
Copy link
Owner

If you want to run the code under MIT, maybe you can pressure the Clustering.jl maintainers to merge the the PR... Then at least GPLv2 is good for something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants