Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugger statements lack sourcemaps #502

Closed
wants to merge 0 commits into from

Conversation

connor4312
Copy link
Contributor

Fixes #501
Fixes microsoft/vscode-js-debug#954

This fixes the linked issue in js-debug, since because the debugger statement didn't have a sourcemap, we were showing paused at the previous, closest position in the source.

I also realized when I added tests in #354, I forgot to actually add the assertion that mappings existed. Oops 馃槃

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #502 (e7e9d7c) into master (d3e22f9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files           1        1           
  Lines        1134     1134           
=======================================
  Hits         1077     1077           
  Misses         57       57           
Impacted Files Coverage 螖
src/astring.js 94.97% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d3e22f9...e7e9d7c. Read the comment docs.

@davidbonnet
Copy link
Owner

Thanks @connor4312 for reporting and handling this issue.
Looks good but an extra fixture folder isn't required. I'll update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger statements lack sourcemaps Debugging pretty printed eval is off by a line
2 participants