-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate golden images to make file paths compatible with go get #357
Regenerate golden images to make file paths compatible with go get #357
Conversation
Yeah, I should remove the docker images as they're for older Ubuntu versions and no longer relevant. The PPA was needed for older Ubuntus without recent libvips. but there's an LTS now with a current libvips so it's not necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI likes your pictures (or uses different library versions)
@AttilaTheFun thanks for this, go get fixed. Curious to know why it would be breaking go get? |
@sonu27 Go get fails if the filenames have colons in them. @tonimelisma accidentally broke this when adding the vips version which contains a timestamp to the file names. I updated the logic to sanitize the file names, replacing those characters with hyphens. That didn't automatically update the images, though, so I had to delete and regenerate them. |
@AttilaTheFun Thanks for the fix! It's appreciated. I am still seeing the error in for v2.12.0 via $ go get -u github.com/davidbyttow/govips/v2/vips@v2.12.0
go: downloading github.com/davidbyttow/govips/v2 v2.12.0
go get github.com/davidbyttow/govips/v2/vips@v2.12.0: create zip: resources/avif-8bit.Export_AVIF_8_Bit-linux-jammy_amd64_libvips-8.12.1-Wed Feb 2 14:43:28 UTC 2022.golden.avif: malformed file path "resources/avif-8bit.Export_AVIF_8_Bit-linux-jammy_amd64_libvips-8.12.1-Wed Feb 2 14:43:28 UTC 2022.golden.avif": invalid char ':'
resources/avif-8bit.Export_AVIF_8_Bit-linux-kinetic_amd64_libvips-8.13.0-Tue Aug 23 04:05:08 UTC 2022.golden.avif: malformed file path "resources/avif-8bit.Export_AVIF_8_Bit-linux-kinetic_amd64_libvips-8.13.0-Tue Aug 23 04:05:08 UTC 2022.golden.avif": invalid char ':'
resources/bmp.Decode_BMP-linux-jammy_amd64_libvips-8.12.1-Wed Feb 2 14:43:28 UTC 2022.golden.png: malformed file path "resources/bmp.Decode_BMP-linux-jammy_amd64_libvips-8.12.1-Wed Feb 2 14:43:28 UTC 2022.golden.png": invalid char ':'
etc. |
@NatashaMitchko You can use the fixed commit by replacing the version with the SHA of the commit at the head of master: Once @tonimelisma / @davidbyttow publish a new version you'll be able to go get it normally. |
This PR fixes #353
I previously landed a PR to normalize the golden image file paths (replacing unsupported characters with hyphens), but CI didn't automatically regenerate the images.
This PR deletes all of the golden images and then regenerates them with valid file paths.
I ran this locally on my M1 Max MacBook Pro with the current homebrew vips release, 8.14.2_1.
I also tried to run the build/build.sh script as well to generate the linux versions with docker, but this seems to rely on one of
@tonimelisma 's private packages so it failed: