-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple selectors #16
Comments
Thanks for the input, that use case makes sense to me. I could see how it would be useful to have |
@davidcalhoun @anichols-ht Created this PR #19 , let me know how we can get it to the finish line :) |
@davidcalhoun can you publish a new version of the package and close this ticket? |
Sorry for the delay, I wanted to make sure there was good test coverage. I've now added it and published a new release - multiple test selectors are now supported as of v2.1.0! Thanks folks! |
How open would you be to the
testAttribute
config property being an array (string or array I guess)? Normally you want to enforce consistency, but here's my reasoning. You can't destructure 'data-test-id' in props because it's not a valid variable name, so I'd love to be able to do this:Currently that doesn't work. I'd have to use data-test everywhere, and then in the actual component do something like
Either that or an option to turn the rule off for all components and only enforce it on html elements. But I prefer the former cause I do want to enforce
dataTest
being there.The text was updated successfully, but these errors were encountered: