Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple test attributes #19

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

KhaledMohamedP
Copy link
Contributor

@KhaledMohamedP KhaledMohamedP commented Aug 4, 2023

This PR addresses this issue here #16

Support multiple test attributes

Screenshot 2023-08-03 at 9 01 32 PM
{
  "rules": {
    "test-selectors/button": [
      "warn",
      "always",
      { "htmlOnly": true, "testAttribute": ["data-testid", "testId"] }
    ]
}

@anichols-ht
Copy link

This seems reasonable to me, but I'll wait for @davidcalhoun to give the final go.

@davidcalhoun
Copy link
Owner

Great, thank you for the PR! Looks ok on first glance, I haven't had a chance to test it out yet.

@davidcalhoun davidcalhoun merged commit 026f1c5 into davidcalhoun:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants